Fix activating [sources] with relative paths #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran into this as well. It would be great if we could get this in. |
Member
|
LGTM, there is also https://github.com/JuliaLang/Pkg.jl/blob/8f013c7652fd4fbbe044176a585ed0326a703338/src/Operations.jl#L2084-L2100 if you want to use that. |
Member
|
If @KristofferC says it is good then that is enough for me. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
===========================================
+ Coverage 20.66% 50.00% +29.33%
===========================================
Files 27 28 +1
Lines 692 716 +24
===========================================
+ Hits 143 358 +215
+ Misses 549 358 -191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
so... merge...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So.. a very rough attempt to fix #92. Basically, the idea is to just loop over the source
Project.tomland replace the relative paths with absolute paths, before it gets resolved.Seems to work, but I really don't follow the code well enough to know if it's in the right place. Or even the right solution.
cc @KristofferC, should you have any bandwith to take a look at this.